Opened 2 years ago

Closed 2 years ago

#328 closed defect - wrong answer (fixed)

incorrect STOP COLUMN DENSITY

Reported by: Gary J. Ferland Owned by: nobody
Priority: blocker Milestone: C17_branch
Component: etc Version: trunk
Keywords: Cc:

Description

A user sent this sim, reporting that it does not stop at the indicated column density

Title test effect of mettalicity on spin temperature
constant temperature 2.5
hden 1.6 
table ism 
extinguish column 22
CMB, z=0
cosmic rays rate -17.3 
abundance ism no grains
grains ism no qheat
stop temperature 3K linear
%
% this one works properly
% stop column density neutral 9 
% this one does not
stop column density neutral 20. 

The stop column density neutral 9 produces a stop message saying the following:

   Calculation stopped because H0 column dens reached. Iteration 1 of 1

and the column density is correct:

 Hydrogen    9.000  4.919  4.621 (H2)                Log10 Column density (cm^-2)

With the larger column density the stop message says

   Calculation stopped because H0-H0+H2 column dens reached. Iteration 1 of 1

and we have these column densities:

 Hydrogen   19.852 15.275 19.208 (H2)                Log10 Column density (cm^-2)

The behavior is the same on c13_branch and the trunk.

The large column density sim has significant H2. It looks like the NEUTRAL and ATOMIC keywords are swapped around?? What does

H0-H0+H2

mean??

Maybe this is a time to remove these special cases and simply stop on a species column density.

Change History (1)

comment:1 Changed 2 years ago by Gary J. Ferland

Resolution: fixed
Status: newclosed

fixed in r10478 and r10480 to c13_branch and r10479 to the trunk. The c13_branch test suite ran clean so the fix had no effect on these cases.

Note: See TracTickets for help on using tickets.